Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump Terraform to 1.0.0 and azurerm to 2.63 #257

Merged
merged 4 commits into from
Jun 18, 2021

Conversation

Chambras
Copy link
Contributor

Updated Docker file to easily use latest versions. Also, tflint support added.

Description

Just updated the Docker file inside the .devcontainer folder to expose tooling versions as arguments so it is easy to update to latest versions of the tooling.
I also added extra steps to install and configure tflint with azurerm support.

Issue reference

The issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles or validates correctly
  • BASH scripts have been validated using shellcheck
  • All tests pass (manual and automated)
  • The documentation is updated to cover any new or changed features
  • Markdown files have been linted using the recommended linter. (See .vscode/extensions.json.)
  • Relevant issues are linked to this PR

@glennmusa glennmusa self-assigned this Jun 18, 2021
Copy link
Contributor

@glennmusa glennmusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few things to consider with regard to azurerm 2.63 and the version of az CLI to pin.

One more thing, we squash and merge in this repository so the PR titles are what make up our git log. Please change the title to what change has occurred like: bump Terraform to 1.0.0 and azurerm to 2.63

.devcontainer/Dockerfile Outdated Show resolved Hide resolved
.devcontainer/Dockerfile Show resolved Hide resolved
@glennmusa
Copy link
Contributor

Another change, the version constraint within a provider block (like we do when pulling in time) is no longer supported and would need to be removed:

provider "time" {
  version = "0.7.1"
}

to

provider "time" {
}

from https://github.com/Chambras/missionlz/blob/d9e847b0e13ea42f5a2e11209cf237c6169e4b4c/src/core/saca-hub/main.tf#L40

@Chambras
Copy link
Contributor Author

I believe I made all suggested changes. Please do let me know if I missed something.

@glennmusa glennmusa changed the title Updated Docker file to easily use latest versions bump Terraform to 1.0.0 and azurerm to 2.63 Jun 18, 2021
@glennmusa glennmusa merged commit c2cbbfe into Azure:main Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants