Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a small issue with the clean.sh script #265

Merged
merged 2 commits into from
Jun 30, 2021

Conversation

Chambras
Copy link
Contributor

Description

A small fix in the clean.sh script to use the SP AppID instead of the SP display name to delete it.

Issue reference

NA

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • [ x] Code compiles or validates correctly
  • [ x] BASH scripts have been validated using shellcheck
  • [ x] All tests pass (manual and automated)
  • [ x] The documentation is updated to cover any new or changed features
  • [ x] Markdown files have been linted using the recommended linter. (See .vscode/extensions.json.)
  • [ x] Relevant issues are linked to this PR

@Chambras Chambras requested a review from glennmusa June 28, 2021 16:31
Copy link
Contributor

@brooke-hamilton brooke-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this fixed the issue with deleting SPs.

@brooke-hamilton brooke-hamilton merged commit 12dba63 into Azure:main Jun 30, 2021
@Chambras Chambras deleted the CleanScript branch July 1, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants