Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused terraform variables #274

Merged
merged 8 commits into from
Jul 6, 2021
Merged

remove unused terraform variables #274

merged 8 commits into from
Jul 6, 2021

Conversation

glennmusa
Copy link
Contributor

Description

There's legacy variables in the codebase like create_network_watcher among other things. This change removes the unused terraform variables under src/terraform and updates the .samples files to reflect variables accurately.

Issue reference

The issue this PR will close: #158

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles or validates correctly
  • BASH scripts have been validated using shellcheck
  • All tests pass (manual and automated)
  • The documentation is updated to cover any new or changed features
  • Markdown files have been linted using the recommended linter. (See .vscode/extensions.json.)
  • Relevant issues are linked to this PR

@glennmusa glennmusa changed the title remove unused unused terraform variables remove unused terraform variables Jul 2, 2021
Copy link
Contributor

@Breanna-Stryker Breanna-Stryker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, variables all look good, and a test deployment on commercial worked just fine.

@glennmusa glennmusa merged commit 9931d2c into main Jul 6, 2021
@glennmusa glennmusa deleted the glenn/removeunusedvars branch July 6, 2021 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the default JSON and .tfvars files with values actually used in configuration
2 participants