Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug where config resources were always created in the Hub subscription #303

Merged
merged 1 commit into from
Jul 21, 2021

Conversation

glennmusa
Copy link
Contributor

Description

Fixes a bug where deploy.sh will fail because it will always look in the hub subscription for the Terraform state storage account:

src/scripts/deploy.sh -s {config_sub_id} \
-u {hub_sub_id} \
-0 {t0_sub_id} \
-1 {t1_sub_id} \
-2 {t2_sub_id} \
-3 {t3_sub_id}

Would result in a Terraform initialization that specified the hub_sub_id as the place to search for Terraform state regardless of where it was actually deployed.

Issue reference

The issue this PR will close: #302

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles or validates correctly
  • BASH scripts have been validated using shellcheck
  • All tests pass (manual and automated)
  • The documentation is updated to cover any new or changed features
  • Markdown files have been linted using the recommended linter. (See .vscode/extensions.json.)
  • Relevant issues are linked to this PR

@glennmusa glennmusa merged commit 7161396 into main Jul 21, 2021
@glennmusa glennmusa deleted the glennmusa/mlzconfiganywhere branch July 21, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MLZ Configuration Resources (TF State, Key Vaults) are always created in the Hub subscription
2 participants