Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update types and descriptions for Terraform modules #408

Merged
merged 2 commits into from
Sep 14, 2021

Conversation

Chambras
Copy link
Contributor

Description

  • Fixed some warning notifications due to missing types and outputs/variables files.
  • Added sensitive flags to some variables.
  • Updated some descriptions for better documentation.

These changes were tested in Azure Commercial and Government (usgovvirginia).

Issue reference

NA

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles or validates correctly
  • BASH scripts have been validated using shellcheck
  • All tests pass (manual and automated)
  • The documentation is updated to cover any new or changed features
  • Markdown files have been linted using the recommended linter. (See .vscode/extensions.json.)
  • Relevant issues are linked to this PR

@glennmusa glennmusa changed the title Updating modules files update types and descriptions for Terraform modules Sep 14, 2021
Copy link
Contributor

@glennmusa glennmusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appreciate the attention to detail @Chambras

@glennmusa glennmusa merged commit ed75cac into Azure:main Sep 14, 2021
@Chambras Chambras deleted the ModulesUpdate branch September 14, 2021 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants