Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a Bicep implementation and remove bash scripts #425

Merged
merged 21 commits into from
Sep 22, 2021
Merged

add a Bicep implementation and remove bash scripts #425

merged 21 commits into from
Sep 22, 2021

Conversation

glennmusa
Copy link
Contributor

Description

This change adds a Bicep implementation of Mission LZ and removes the Mission LZ-specific Terraform wrapper scripts in favor of a vanilla Terraform CLI deployment.

See src/bicep/README.md for instructions on deploying the Bicep implementation.

See src/terraform/README.md for instructions on deploying the Terraform implementation.

Issue reference

The issue this PR will close #420

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles or validates correctly
  • BASH scripts have been validated using shellcheck
  • All tests pass (manual and automated)
  • The documentation is updated to cover any new or changed features
  • Markdown files have been linted using the recommended linter. (See .vscode/extensions.json.)
  • Relevant issues are linked to this PR

@brooke-hamilton brooke-hamilton self-assigned this Sep 22, 2021
Copy link
Contributor

@brooke-hamilton brooke-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 🥇

@glennmusa glennmusa merged commit d172780 into main Sep 22, 2021
@glennmusa glennmusa deleted the bicep branch January 19, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge the bicep branch to main
6 participants