Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pr template #429

Merged
merged 4 commits into from
Sep 22, 2021
Merged

Update pr template #429

merged 4 commits into from
Sep 22, 2021

Conversation

brooke-hamilton
Copy link
Contributor

@brooke-hamilton brooke-hamilton commented Sep 22, 2021

Description

Updated the PR template to remove things that are automated checks.

Issue reference

The issue this PR will close: #399

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles or validates correctly
[ ] BASH scripts have been validated using shellcheck
[ ] All tests pass (manual and automated)

  • The documentation is updated to cover any new or changed features
    [ ] Markdown files have been linted using the recommended linter. (See .vscode/extensions.json.)
  • Relevant issues are linked to this PR

@brooke-hamilton brooke-hamilton enabled auto-merge (squash) September 22, 2021 17:52
@brooke-hamilton brooke-hamilton requested a review from a team September 22, 2021 17:53
Copy link
Contributor

@glennmusa glennmusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nit about extra whitespace in the checklist instructions

@glennmusa glennmusa self-requested a review September 22, 2021 19:09
Copy link
Contributor

@glennmusa glennmusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

realizing there's no "approve with suggestions"

Copy link
Contributor

@glennmusa glennmusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

took off auto-merge -- maybe that's approve with suggestions 😅

Co-authored-by: Glenn Musa <4622125+glennmusa@users.noreply.github.com>
@brooke-hamilton brooke-hamilton merged commit 7d9aa3e into main Sep 22, 2021
@brooke-hamilton brooke-hamilton deleted the brooke/prtemplate branch September 22, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update pull request template
2 participants