Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove validate, update build workflows. #444

Merged
merged 6 commits into from
Oct 7, 2021

Conversation

Breanna-Stryker
Copy link
Contributor

Description

The validate bicep action is replaced with a validate-build action to only fire on pull_requests to the main branch and not to other protected branches. The failure to commit/build correctly was based on a detached head issue. This has been fixed with some work arounds;. The status failure to push when there isn't a difference between the mlz.json file builds, has been covered with a git status check.

To Test: Branch from this branch 'breestryker/validateactionbuildrepair' make changes to the bicep files under src/bicep and create a mock PR to main. The workflow action should fire.

Issue reference

The issue this PR will close: #426

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

@Breanna-Stryker Breanna-Stryker requested a review from a team October 7, 2021 15:45
Copy link
Contributor

@glennmusa glennmusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to do the trick. Mind giving a demo/walk-through after the next standup using breestryker/validateactionbuildrepair?

@Breanna-Stryker Breanna-Stryker merged commit a1c89ff into main Oct 7, 2021
@Breanna-Stryker Breanna-Stryker deleted the breestryker/validateactionbuildrepair branch October 7, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants