Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix transposed hub network peerings #451

Merged
merged 2 commits into from
Oct 11, 2021
Merged

fix transposed hub network peerings #451

merged 2 commits into from
Oct 11, 2021

Conversation

glennmusa
Copy link
Contributor

Description

This change fixes the transposed virtual network resource IDs in the Hub Network peerings.

Issue reference

The issue this PR will close: #450

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

@glennmusa glennmusa requested a review from a team October 11, 2021 20:09
@jjansen23 jjansen23 self-assigned this Oct 11, 2021
@glennmusa glennmusa merged commit 077d545 into main Oct 11, 2021
@glennmusa glennmusa deleted the glenn/updateHubPeering branch October 11, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjansen23 jjansen23 jjansen23 approved these changes

Assignees

@jjansen23 jjansen23

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Potential mistake on grabbing the network resource ID in the hub peering Bicep
2 participants
@glennmusa @jjansen23