Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove virtual network diagnostics from Terraform #476

Merged
merged 3 commits into from
Oct 21, 2021

Conversation

glennmusa
Copy link
Contributor

Description

Remove the virtual network 'AllMetrics' diagnostic setting from the Terraform deployment since it does not add value out-of-the-box but can be enabled any time by a user post-deployment.

Issue reference

The issue this PR will close: #474

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

@glennmusa glennmusa requested review from shawngib and a team October 21, 2021 15:24
Copy link
Member

@shawngib shawngib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@glennmusa glennmusa merged commit e043ce3 into main Oct 21, 2021
@glennmusa glennmusa deleted the glenn/removeVnetAllMetrics branch October 21, 2021 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the AllMetrics virtual network diagnostics setting from Terraform
2 participants