Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Readme with Firewall information #477

Merged
merged 12 commits into from
Oct 26, 2021
Merged

Conversation

lisamurphy-msft
Copy link
Contributor

@lisamurphy-msft lisamurphy-msft commented Oct 21, 2021

Description

Updated the README.md file with Firewall information. Will keep this in Draft mode as additional requests for documentation updating might be needed here depending on the granularity we want to include.

Issue reference

The issue this PR will close: #232

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

@lisamurphy-msft lisamurphy-msft marked this pull request as draft October 21, 2021 18:03
@lisamurphy-msft lisamurphy-msft marked this pull request as ready for review October 25, 2021 14:10
@shawngib
Copy link
Member

Is there any value in making note that the defaults rule are specific to Azure Portal, Azure Cli and Azure PowerShell access? Meaning that is why it was done but this does cover what was done very nicely.

@lisamurphy-msft
Copy link
Contributor Author

That is a valid point, I'm not certain what value adding context to an IT administrator is with that information.
My original thought was to be much more verbose, but it wasn't following the flow of the original documentation.

README.md Outdated Show resolved Hide resolved
lisamurphy-msft and others added 2 commits October 26, 2021 07:09
Co-authored-by: Glenn Musa <4622125+glennmusa@users.noreply.github.com>
@lisamurphy-msft lisamurphy-msft merged commit 6bdbf97 into main Oct 26, 2021
@lisamurphy-msft lisamurphy-msft deleted the issue232-temp branch October 26, 2021 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide documentation for the firewall and hub settings that are applied
3 participants