Regenerated new workload ARM template and added missing module param

[brooke-hamilton]

Description

Regenerated the ARM template from the Bicep template. Also fixed an issue in which the spokeType parameter was not being supplied for the workloadVirtualNetworkPeerings module.

Issue reference

The issue this PR will close: #501

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

• All acceptance criteria in the backlog item are met
• The documentation is updated to cover any new or changed features
• Manual tests have passed
• Relevant issues are linked to this PR

[brooke-hamilton]

@glennmusa please verify that using workloadName is the right value to use for the spokeType parameter. A 'type' and a 'name' are not always the same thing, but in this case I think we should use the workload name as the spoke type so that we can support unique and multiple workload names. Or maybe I'm wrong and all new workloads should use the same value for spokeType.

[glennmusa]

@glennmusa please verify that using workloadName is the right value to use for the spokeType parameter. A 'type' and a 'name' are not always the same thing, but in this case I think we should use the workload name as the spoke type so that we can support unique and multiple workload names. Or maybe I'm wrong and all new workloads should use the same value for spokeType.

I think you're right that a type and a name are not the same thing. This looks like a miss on my part.

In fact, the spoke "Type" I created in the root module does use a name property and not a type property:

missionlz/src/bicep/mlz.bicep

Lines 557 to 559 in b39c930

	var spokes = [
	{
	name: 'operations'

I think the right thing to do here would be to rename the spokeType parameter to spokeName in the spokeNetworkPeering module to reflect that:

missionlz/src/bicep/modules/spokeNetworkPeering.bicep

Line 3 in b39c930

param spokeType string

Good catch! Happy to pair up on the change if it bubbles up unwieldly.

[glennmusa]

Agree on your changes for spokeType => spokeName

[brooke-hamilton]

Agree on your changes for spokeType => spokeName

Done. Please re-review. 💯

[glennmusa]

🎉