Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix private link scopes #510

Merged
merged 3 commits into from
Nov 9, 2021
Merged

Fix private link scopes #510

merged 3 commits into from
Nov 9, 2021

Conversation

jjansen23
Copy link
Contributor

@jjansen23 jjansen23 commented Nov 9, 2021 •
edited
Loading

Description

Please explain the changes you've made

Modified the hubNetwork bicep file to only call the privateLink bicep file for the supported clouds.

Issue reference

#508
The issue this PR will close: #508

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

@glennmusa glennmusa self-assigned this Nov 9, 2021
@jjansen23 jjansen23 merged commit b95d3ee into main Nov 9, 2021
@jjansen23 jjansen23 deleted the fixPrivateLinkScopes branch November 9, 2021 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennmusa glennmusa glennmusa approved these changes

Assignees

@glennmusa glennmusa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change code to NOT deploy PrivateLinkScopes, except when in Public or Azure Government cloud
2 participants
@jjansen23 @glennmusa