Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy App Service Plan - MLZ Example #526

Merged
merged 17 commits into from
Nov 24, 2021
Merged

Conversation

ExchMaster
Copy link
Contributor

Description

This update adds a new example workload deployment. Specifically, it enables the deployment of an App Service Plan suitable for hosting Linux web applications using docker containers. Here are some of the details of the implementation:

  • Updates mlz.bicep to include resourcePrefix as an deployment output. This allows examples to pick up the resourcePrefix straight from the deploymentVariables file. User can specify their own name via param if desired.
  • Modified gitignore by adding a single line exception permitting files with the name 'plan' and in the ./src/bicep/* to be committed via git.
  • Enabled the ability for the user doing the deployment to use custom resource group and specific subscription if desired. If unspecified, the default behavior is to deploy into an appropriate MLZ resource group with corresponding subscription. In this case, the shared services resource group.

Note: This example does not also deploy a web application because the target audience for this particular sample is the engineering/admin team. A separate example showing how to deploy a Linux web app container on docker will be forthcoming which is aimed at the dev team.

This update uses the bicep shared variable file pattern as described here: https://docs.microsoft.com/en-us/azure/azure-resource-manager/bicep/patterns-shared-variable-file

Issue reference

This PR is related to the following issue: #517
I did attempt to retrieve MLZ outputs using a deployment object, but ultimately failed to successfully do so do the dynamic nature of how the outputs are parsed/discovered at run-time. More research is needed, but felt this pattern solved the majority of the issue and is worthy of doing now while we continue to investigate how to use deployment objects for this problem.

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • [see above] All acceptance criteria in the backlog item are met
  • [ *] The documentation is updated to cover any new or changed features
  • [ *] Manual tests have passed
  • [ *] Relevant issues are linked to this PR

@glennmusa glennmusa self-assigned this Nov 16, 2021
Copy link
Contributor

@glennmusa glennmusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Some minor nits and questions. My primary feedback is for allowing for the default parameter override behavior of ARM and Bicep. 👍

src/bicep/examples/appServicePlan/appService.bicep Outdated Show resolved Hide resolved
src/bicep/examples/appServicePlan/README.md Outdated Show resolved Hide resolved
.gitignore Show resolved Hide resolved
@Azure Azure deleted a comment from glennmusa Nov 17, 2021
@ExchMaster ExchMaster dismissed glennmusa’s stale review November 22, 2021 15:41

Cause I don't know how to show that it's resolved. The requested change has been implemented. :/

Copy link
Contributor

@brooke-hamilton brooke-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still reviewing but leaving these simple things here while I do deployments.

src/bicep/examples/appServicePlan/README.md Outdated Show resolved Hide resolved
src/bicep/examples/appServicePlan/README.md Outdated Show resolved Hide resolved
src/bicep/examples/appServicePlan/README.md Outdated Show resolved Hide resolved
src/bicep/examples/deploymentVariables.json Outdated Show resolved Hide resolved
src/bicep/examples/appServicePlan/README.md Outdated Show resolved Hide resolved
src/bicep/examples/appServicePlan/appService.bicep Outdated Show resolved Hide resolved
ExchMaster and others added 7 commits November 22, 2021 18:09
Co-authored-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Co-authored-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Co-authored-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Co-authored-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Copy link
Contributor

@brooke-hamilton brooke-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the changes. ❤️

@brooke-hamilton brooke-hamilton merged commit cdd9c3f into main Nov 24, 2021
@brooke-hamilton brooke-hamilton deleted the jai-AppServicePlan branch November 24, 2021 17:38
Copy link
Contributor

@brooke-hamilton brooke-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployed successfully. Minor changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants