Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating roleAssignment.bicep expected values #534

Merged
merged 2 commits into from
Nov 18, 2021
Merged

Updating roleAssignment.bicep expected values #534

merged 2 commits into from
Nov 18, 2021

Conversation

lisamurphy-msft
Copy link
Contributor

@lisamurphy-msft lisamurphy-msft commented Nov 18, 2021 •
edited
Loading

Description

Updated the expected values in roleAssignment.bicep

Issue reference

The issue this PR will close: #486

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

shawngib
shawngib approved these changes Nov 18, 2021
View reviewed changes
Copy link
Member

@shawngib shawngib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basic tests works without warning.

@lisamurphy-msft lisamurphy-msft merged commit 8b66262 into main Nov 18, 2021
@lisamurphy-msft lisamurphy-msft deleted the issue-486-temp branch November 18, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawngib shawngib shawngib approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the roleAssignment.bicep module principalType property so that warnings do not occur
2 participants
@lisamurphy-msft @shawngib