Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified tags to support add values and removing default #537

Merged
merged 9 commits into from
Nov 19, 2021

Conversation

shawngib
Copy link
Member

Description

Added the ability to use the tags parameter to add additional tags but not lose the default tags. Customers can still use something like tags='{"Owner":"Contoso","Cost Center":"2345-324"}' in bash to create a tag object then deploy with parameters like --parameters resourcePrefix="mlz-prod" deployASC="true" deployPolicy=true policy="CMMC" tags="$tags" which will not replace the current default use of prefix and deployment type tags.

Issue reference

The issue this PR will close: #530

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

Copy link
Contributor

@glennmusa glennmusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense 👍. Have a nit regarding the variable name and wonder if the policy change should be in another merge.

Some more Boy Scouting, I noticed the hub resource group is missing a tags assignment. Can we update that in this change too?

module hubResourceGroup './modules/resourceGroup.bicep' = {
name: 'deploy-rg-hub-${nowUtc}'
scope: subscription(hubSubscriptionId)
params: {
name: hubResourceGroupName
location: hubLocation
}
}

src/bicep/mlz.bicep Outdated Show resolved Hide resolved
@glennmusa glennmusa merged commit d2cafe3 into main Nov 19, 2021
@glennmusa glennmusa deleted the shawng/modify-tags-to-keep-default branch November 19, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify tags to allow adding custom tags without impacting default tags
2 participants