Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default NSG rules for 22 and 3389 from Bicep deployment #538

Merged
merged 3 commits into from
Nov 19, 2021

Conversation

vidyambala
Copy link
Contributor

@vidyambala vidyambala commented Nov 18, 2021

Description

Removed the default values of Hub NSG rules

Issue reference

The issue this PR will close: #443

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

@glennmusa glennmusa changed the title Modify NSG in hub Resource Group #443 Remove default NSG rules for 22 and 3389 from Bicep deployment Nov 19, 2021
@glennmusa glennmusa self-assigned this Nov 19, 2021
Copy link
Contributor

@glennmusa glennmusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bastion host remote connections over SSH and RDP continue to work after removing these NSG rules with this deployment:

my_password=$(openssl rand -base64 14)
az deployment sub create \
  --name "pr538a" \
  --location "eastus" \
  --template-file "src/bicep/mlz.bicep" \
  --parameters deployRemoteAccess="true" \
  --parameters linuxVmAdminPasswordOrKey="$my_password" \
  --parameters windowsVmAdminPassword="$my_password"

@shawngib
Copy link
Member

Not sure I understand the bug since this is most likely not related to our Allow RDP or SSH rule and related to 'AllowVnet' inbound and outbound and bastions in vNet? We should consider enabling JIT on jumpboxes, which is a larger feature add, as it is a compliance requirement in zero trust and other regulations. @Phydeauxman would that solve the problem you are trying to solve?

It does appear it is assigned: I manually deleted allow rdp and ssh in below and tested new branch. I also do not understand priority.
image

@glennmusa
Copy link
Contributor

Not sure I understand the bug since this is most likely not related to our Allow RDP or SSH rule and related to 'AllowVnet' inbound and outbound and bastions in vNet?

I think the purpose of this specific branch is just to remove these unused rules.

I agree JIT could be a better answer but would require more thought.

@shawngib
Copy link
Member

If that is the purpose, then done. But it is connected to a bug that will not be changed based on this branch and arguably isn't a bug since 'working as normal' ;)

@vidyambala vidyambala enabled auto-merge (squash) November 19, 2021 17:21
@vidyambala vidyambala merged commit 6b6e740 into main Nov 19, 2021
@vidyambala vidyambala deleted the vidbala/nsgrule branch November 19, 2021 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify NSG in hub Resource Group
3 participants