deploy Azure Container Registry Example #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooke-hamilton
suggested changes
Nov 24, 2021
Co-authored-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Co-authored-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
brooke-hamilton
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This example deploys a premium Azure Container Registry suitable for hosting docker containers. The registry will be deployed to the MLZ shared services resource group using default naming unless alternative values are provided at run time.
This update uses the bicep shared variable file pattern as described here: https://docs.microsoft.com/en-us/azure/azure-resource-manager/bicep/patterns-shared-variable-file
Issue reference
This PR is related to the following issue: #517
I did attempt to retrieve MLZ outputs using a deployment object, but ultimately failed to successfully do so do the dynamic nature of how the outputs are parsed/discovered at run-time. More research is needed, but felt this pattern solved the majority of the issue and is worthy of doing now while we continue to investigate how to use deployment objects for this problem.
Checklist
Please make sure you've completed the relevant tasks for this PR out of the following list:
NOTE: I am adding multiple examples quickly with over-lapping pull-requests so in an effort to avoid merge conflicts I was planning on updating the ./src/bicep/examples/README.md with all the information at once. I did add an initial update in my first PR to that ReadMe updating the docs on creating the deployment Variables file. I'll come back and update the index of examples after I update/add a few more of them.