Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Azure KeyVault (Premium, RBAC) #544

Merged
merged 10 commits into from
Nov 30, 2021
Merged

Conversation

ExchMaster
Copy link
Contributor

Description

Added an example bicep template which enables the deployment of Azure Key Vault. The Key Vault will deploy into default MLZ resource groups using default MLZ naming conventions unless those values are overwritten at run time via parameters.

The key vault will deploy enabled for RBAC and using the premium SKU for HSM backed keys.

This update uses the bicep shared variable file pattern as described here: https://docs.microsoft.com/en-us/azure/azure-resource-manager/bicep/patterns-shared-variable-file

Issue reference

This PR is related to the following issue: #517
I did attempt to retrieve MLZ outputs using a deployment object, but ultimately failed to successfully do so do the dynamic nature of how the outputs are parsed/discovered at run-time. More research is needed, but felt this pattern solved the majority of the issue and is worthy of doing now while we continue to investigate how to use deployment objects for this problem.

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • [see above] All acceptance criteria in the backlog item are met
  • [ x] The documentation is updated to cover any new or changed features
  • [ x] Manual tests have passed
  • [ x] Relevant issues are linked to this PR

src/bicep/examples/deploymentVariables.json Outdated Show resolved Hide resolved
src/bicep/mlz.json Outdated Show resolved Hide resolved
src/bicep/examples/keyVault/README.md Outdated Show resolved Hide resolved
src/bicep/examples/keyVault/README.md Outdated Show resolved Hide resolved
src/bicep/examples/keyVault/README.md Outdated Show resolved Hide resolved
ExchMaster and others added 5 commits November 29, 2021 13:39
Co-authored-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Co-authored-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Co-authored-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Copy link
Contributor

@brooke-hamilton brooke-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ExchMaster thank you! 🥇

@brooke-hamilton brooke-hamilton merged commit f28fa51 into main Nov 30, 2021
@brooke-hamilton brooke-hamilton deleted the jai-deployKeyVault branch November 30, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants