Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce a mandatory resourcePrefix parameter #553

Merged
merged 4 commits into from
Dec 3, 2021
Merged

Enforce a mandatory resourcePrefix parameter #553

merged 4 commits into from
Dec 3, 2021

Conversation

glennmusa
Copy link
Contributor

Description

This change:

  • makes resourcePrefix a mandatory parameter
  • removes deployment().name as a seed for resource names and uniqueness
  • uses resourcePrefix for resource names
  • uses resourcePrefix + utcNow() to generates uniqueness
  • updates Azure DevOps pipelines to ensure a resourcePrefix parameter is supplied to deployment commands
  • updates documentation to inform users that this parameter is now mandatory and used for naming

Issue reference

The issue this PR will close: #552

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

@glennmusa glennmusa added this to the Resource Naming milestone Dec 3, 2021
@glennmusa glennmusa requested a review from a team December 3, 2021 15:52
@glennmusa glennmusa closed this Dec 3, 2021
@glennmusa glennmusa reopened this Dec 3, 2021
@glennmusa
Copy link
Contributor Author

Troubleshooting why I'm seeing Expected -- Waiting for status to be reported on all Azure DevOps Pipelines.

Giving this command a shot:

/AzurePipelines run

@glennmusa
Copy link
Contributor Author

/AzurePipelines run mlz-pr-bicep-azurecloud

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@glennmusa glennmusa enabled auto-merge (squash) December 3, 2021 17:09
@glennmusa glennmusa merged commit 52aeca1 into main Dec 3, 2021
@glennmusa glennmusa deleted the glenn/resourcePrefixParam branch December 3, 2021 18:04
@glennmusa glennmusa mentioned this pull request Dec 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vidyambala vidyambala vidyambala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Resource Naming
Development

Successfully merging this pull request may close these issues.

Require a user-supplied value for resourcePrefix and do not use deployment().name for seeding names
2 participants
@glennmusa @vidyambala