Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable intrusion detection (IDPS) by default #555

Merged
merged 4 commits into from
Dec 3, 2021
Merged

Conversation

brooke-hamilton
Copy link
Contributor

Description

Enables IDPS by default and provides a parameter for setting the IDPS value.

Also added validation to the threadIntelMode parameter. Both parameters use the same list of allowed values: Alert, Deny, Off.

Issue reference

The issue this PR will close: #539

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • [] The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

@brooke-hamilton brooke-hamilton enabled auto-merge (squash) December 3, 2021 18:12
auto-merge was automatically disabled December 3, 2021 18:50

Pull request was closed

@brooke-hamilton
Copy link
Contributor Author

Closing and re-opening in hopes that it will re-trigger the stuck PR checks. 😸

@glennmusa
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@brooke-hamilton brooke-hamilton enabled auto-merge (squash) December 3, 2021 19:41
@brooke-hamilton brooke-hamilton merged commit 894aaea into main Dec 3, 2021
@brooke-hamilton brooke-hamilton deleted the brooke/idps branch December 3, 2021 19:54
@glennmusa
Copy link
Contributor

Closing and re-opening in hopes that it will re-trigger the stuck PR checks. 😸

Something smells wrong, right? Let's see if a third PR doesn't trigger the checks. If that happens, we have a pattern and we can refresh the GitHub App in ADO/rebuild the service connection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Azure Firewall Intrusion Detection policy by default
2 participants