Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a default resource naming convention to mlz.bicep #558

Merged
merged 16 commits into from
Dec 7, 2021

Conversation

glennmusa
Copy link
Contributor

@glennmusa glennmusa commented Dec 6, 2021

Description

So that deployed resources adopt generally accepted naming practices while providing a single place in source to modify the naming convention, this change introduces a default naming convention to mlz.bicep:

var namingConvention = '${toLower(resourcePrefix)}-${resourceToken}-${nameToken}-${toLower(resourceSuffix)}'

These changes:

  • adopts a naming convention for the resources named at mlz.bicep
  • uses the recommended abbreviations where possible
  • provide an obvious mechanism to override naming conventions
  • documents how to override naming conventions
  • ensures all resource names are in lower case
  • adds an additional optional parameter resourceSuffix that defaults to "mlz"
  • includes resourceSuffix in automatic tags.
  • updates the uniqueString() seed for storage accounts makes use of resourcePrefix and resourceSuffix
  • the storage accounts can be deployed multiple times without destroying and recreating, preserving idempotency
  • updates the AzurePolicyforLinux extension name for the Linux jumpbox to match the documented API

Issue reference

The issue this PR will closes: #556 #559

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

@glennmusa glennmusa added this to the Resource Naming milestone Dec 6, 2021
@glennmusa glennmusa requested a review from a team December 6, 2021 17:34
@glennmusa glennmusa marked this pull request as draft December 6, 2021 18:04
@glennmusa glennmusa marked this pull request as ready for review December 6, 2021 19:27
@glennmusa glennmusa linked an issue Dec 6, 2021 that may be closed by this pull request
vidyambala
vidyambala previously approved these changes Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linux jumpbox provisioning fails intermittently on policy extensions Create naming conventions for resources
3 participants