Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update securityCenter.bicep module API provider to prevent warnings #560

Merged
merged 11 commits into from
Jan 26, 2022

Conversation

lisamurphy-msft
Copy link
Contributor

@lisamurphy-msft lisamurphy-msft commented Dec 7, 2021

Description

removed invalid parameters in securityCenter.bicep
Tested and observed "ASC Default" policies being applied upon initialization of ASC on account.
image
Also observed the set-hub-sub-security-center deployment completing successfully:
image

No warnings are occurring and this appears to be behaving as expected.

Issue reference

The issue this PR will close: #485

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

@glennmusa
Copy link
Contributor

I noticed that I no longer get the ASC Default Audit policies applied to my subscription after this deployment. Gonna mark as Draft for now just so it doesn't go through without confirming the impact of that change. Will catch up offline!👍

Previously:
image

With these changes:
image

@glennmusa glennmusa marked this pull request as draft December 7, 2021 17:57
@lisamurphy-msft
Copy link
Contributor Author

Proposed changes involve adding a default policyAssignment that originates from the policy initiative "Azure Security Benchmark" and is named "ASC Default" - this has been tested and it has shown that the deployment completes successfully and proves to be idempotent in nature; updating as needed to ensure a consistent baseline policy initiative assignment.

image

Slightly new resource type designation but will create the same policy assignment consistently:

image

@lisamurphy-msft lisamurphy-msft marked this pull request as ready for review January 26, 2022 13:38
@lisamurphy-msft lisamurphy-msft requested a review from a team as a code owner January 26, 2022 13:38
@brooke-hamilton brooke-hamilton changed the title Updated securityCenter.bicep Update securityCenter.bicep module API provider to prevent warnings Jan 26, 2022
@brooke-hamilton brooke-hamilton self-assigned this Jan 26, 2022
Copy link
Contributor

@brooke-hamilton brooke-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To verify this I deployed the main branch to a subscription with deployASC=true. Then I deployed this PR branch to another subscription with deployASC=true. I compared the policy assignments of the two subscriptions and they are almost exactly the same. The difference was an additional policy included in the default initiative, but I'm assuming that's due to using a documented and current API, which is a good thing. Everything about ASC being enabled looks the same as before, except no warnings. 🎆 👍 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Update the securityCenter.bicep module API provider so that warnings do not occur
3 participants