Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relocate Bicep parameters and add descriptions to mlz.bicep #563

Merged
merged 3 commits into from
Dec 8, 2021

Conversation

glennmusa
Copy link
Contributor

Description

Performing source hygiene on mlz.bicep by moving parameters to the beginning of the file and adds description for each parameter.

Issue reference

The issue this PR will close: #529

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

@glennmusa glennmusa added this to the Resource Naming milestone Dec 7, 2021
@glennmusa glennmusa requested a review from a team December 7, 2021 17:53
@glennmusa
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@glennmusa glennmusa enabled auto-merge (squash) December 7, 2021 19:04
@brooke-hamilton brooke-hamilton self-assigned this Dec 7, 2021
Copy link
Contributor

@brooke-hamilton brooke-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ❤️ this PR. None of the comments are required changes - only questions/suggestions.

src/bicep/mlz.bicep Outdated Show resolved Hide resolved
src/bicep/mlz.bicep Outdated Show resolved Hide resolved
src/bicep/mlz.bicep Show resolved Hide resolved
…ed values for Log Analytics Workspace SKU name
@glennmusa
Copy link
Contributor Author

I ❤️ this PR. None of the comments are required changes - only questions/suggestions.

Took your suggestions! Thanks for the thorough review!

@glennmusa glennmusa merged commit d92fb50 into main Dec 8, 2021
@glennmusa glennmusa deleted the glenn/moveParams branch December 8, 2021 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move parameters and variables to beginning of files in Bicep source
2 participants