Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update newWorkload example to resolve naming related conflicts #572

Merged
merged 6 commits into from
Dec 15, 2021

Conversation

ExchMaster
Copy link
Contributor

Description

Updated the newWorkload example in the following ways

Issue reference

The issue this PR will close the following related issues:

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

Copy link
Contributor

@glennmusa glennmusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peered up successfully, created a unique storage account, and truncates the deployment name.

Have a comment in here about naming conventions, but we can plan to solve that for all the add-ons at once instead of piecemeal-ing it one-by-one.

@glennmusa glennmusa changed the title Resolve naming related conflicts, update readme for depVariables Update newWorkload example to resolve naming related conflicts Dec 15, 2021
@glennmusa glennmusa merged commit df05d69 into main Dec 15, 2021
@glennmusa glennmusa deleted the jai-UpdateNewWorkload branch December 15, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants