Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an Azure Portal Form UI #577

Merged
merged 32 commits into from
Dec 15, 2021
Merged

Add an Azure Portal Form UI #577

merged 32 commits into from
Dec 15, 2021

Conversation

glennmusa
Copy link
Contributor

@glennmusa glennmusa commented Dec 15, 2021

Description

Adds a stepped wizard Azure Portal form with input validation and adds the Deploy to Azure buttons to the relevant READMEs.

To demo this (these buttons launch the Custom Portal Blade experience from this branch, /glenn/formUi, the READMEs in this branch are linked to their eventual destination, /main after these changes are merged):

Deploy to Azure

Deploy to AzureGov

This change introduces a form that:

  • uses ArmApiControls to query for the user's subscriptions
  • uses ArmApiControls to query for a list of locations available to the user and trim the list to a specific subset we control
  • uses regex validation to ensure the virtual network and subnet address pairs are valid
  • allows for opt-in of Azure Policy and policy set selection
  • allows for opt-in of Azure Security Center and validation of security contact e-mail address
  • allows for opt-in of Azure Sentinel
  • allows for opt-in of Azure Bastion Host and validation of virtual machine usernames and credentials
  • captures user provided custom tags

Issue reference

The issue this PR will close: #482

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

@glennmusa glennmusa requested a review from a team December 15, 2021 20:17
@brooke-hamilton brooke-hamilton self-assigned this Dec 15, 2021
@brooke-hamilton brooke-hamilton enabled auto-merge (squash) December 15, 2021 22:04
Copy link
Contributor

@brooke-hamilton brooke-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting custom buttons in the PR description was clever because it was not possible to test the buttons from the branch due to the branch path in the template URI. 🥲

@brooke-hamilton brooke-hamilton merged commit 5f88e13 into main Dec 15, 2021
@brooke-hamilton brooke-hamilton deleted the glenn/formUi branch December 15, 2021 22:11
@glennmusa
Copy link
Contributor Author

Putting custom buttons in the PR description was clever because it was not possible to test the buttons from the branch due to the branch path in the template URI. 🥲

It's a tricky dance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Bicep form with pre-deployment input validation
2 participants