Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates and reorganization of deployment guides #595

Merged
merged 66 commits into from
Jan 5, 2022

Conversation

brooke-hamilton
Copy link
Contributor

@brooke-hamilton brooke-hamilton commented Dec 30, 2021

Description

This PR contains documentation updates, including:

  • Consolidation of Bicep deployment instructions into a new docs/deployment-guide-bicep.md file.
  • Moved and updated the terraform deployment instructions into docs/deployment-guide-terraform.md.
  • Implemented a standard table of contents in the Terraform and Bicep deployment docs.
  • Updated the README.md docs at src/terraform and src/bicep to link to the deployment guides.
  • Generated a list of parameters for the Bicep folder documentation at src/bicep/README.md.
  • Removed unused images at docs/images/custom_template_deployment.gif, docs/images/missionlz_as_of_july2021.jpg, and docs/images/missionlz_as_of_may2021.png

Issue reference

The issue this PR will close: #562
The issue this PR will close: #428
The issue this PR will close: #299 (See the Azure Firewall Premium section in deployment-guide-bicep.md.)

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

@brooke-hamilton brooke-hamilton enabled auto-merge (squash) December 30, 2021 22:27
@brooke-hamilton brooke-hamilton changed the title Brooke/docs gettingstarted Updates and reorganization of deployment guides Dec 30, 2021
@brooke-hamilton brooke-hamilton requested a review from a team as a code owner January 4, 2022 16:29
@glennmusa glennmusa self-assigned this Jan 5, 2022
docs/deployment-guide-terraform.md Outdated Show resolved Hide resolved
docs/deployment-guide-bicep.md Outdated Show resolved Hide resolved
docs/deployment-guide-bicep.md Outdated Show resolved Hide resolved
docs/deployment-guide-terraform.md Outdated Show resolved Hide resolved
docs/deployment-guide-terraform.md Show resolved Hide resolved
brooke-hamilton and others added 4 commits January 5, 2022 15:41
Co-authored-by: Glenn Musa <4622125+glennmusa@users.noreply.github.com>
Co-authored-by: Glenn Musa <4622125+glennmusa@users.noreply.github.com>
Co-authored-by: Glenn Musa <4622125+glennmusa@users.noreply.github.com>
Copy link
Contributor

@glennmusa glennmusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@brooke-hamilton brooke-hamilton merged commit 1960d33 into main Jan 5, 2022
@brooke-hamilton brooke-hamilton deleted the brooke/docs-gettingstarted branch January 5, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants