Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tier 3 naming convention #651

Merged
merged 13 commits into from
Feb 23, 2022
Merged

Tier 3 naming convention #651

merged 13 commits into from
Feb 23, 2022

Conversation

vidyambala
Copy link
Contributor

Description

Update 3 workload resource names consistent with other MLZ resource names

Issue reference

The issue this PR will close: #612

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

@vidyambala vidyambala requested a review from a team as a code owner February 16, 2022 02:28
@vidyambala vidyambala closed this Feb 16, 2022
@vidyambala vidyambala reopened this Feb 16, 2022
@glennmusa glennmusa self-assigned this Feb 16, 2022
@glennmusa glennmusa mentioned this pull request Feb 16, 2022
Merged
4 tasks
@vidyambala vidyambala closed this Feb 16, 2022
@vidyambala vidyambala reopened this Feb 16, 2022
glennmusa
glennmusa reviewed Feb 22, 2022
View reviewed changes
Copy link
Contributor

@glennmusa glennmusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some updates to follow conventions that exist elsewhere in the repo and to the docs. Let me know if there's things I've overlooked!👍

src/bicep/examples/newWorkload/README.md Show resolved Hide resolved
src/bicep/examples/newWorkload/newWorkload.bicep Show resolved Hide resolved
src/bicep/examples/newWorkload/newWorkload.bicep Show resolved Hide resolved
src/bicep/examples/newWorkload/newWorkload.bicep Show resolved Hide resolved
@vidyambala vidyambala enabled auto-merge (squash) February 23, 2022 03:35
@vidyambala vidyambala merged commit 606d886 into main Feb 23, 2022
@vidyambala vidyambala deleted the vidbala/t3workload branch February 23, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennmusa glennmusa glennmusa approved these changes

Assignees

@glennmusa glennmusa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make tier 3 workload resource names consistent with other MLZ resource names
2 participants
@vidyambala @glennmusa