Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update examples to include Sentinel Workbook #665

Merged
merged 32 commits into from
Feb 28, 2022
Merged

Update examples to include Sentinel Workbook #665

merged 32 commits into from
Feb 28, 2022

Conversation

lisamurphy-msft
Copy link
Contributor

@lisamurphy-msft lisamurphy-msft commented Feb 23, 2022 •
edited
Loading

Description

Provided deployment instructions for the Sentinel TIC 3.0 Zero Trust Workbook in the examples folder

Issue reference

The issue this PR will close: #258

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

@lisamurphy-msft lisamurphy-msft requested a review from a team as a code owner February 23, 2022 14:31
@lisamurphy-msft
Copy link
Contributor Author

lisamurphy-msft commented Feb 23, 2022 •
edited
Loading

TODO: provide backlog item for

  • Appropriate cards are chosen and checked by default (or generate new work to determine what this is, or how to implement it via a README)
  • For findings reported by the workbook, consider whether new backlog items should be created for MLZ. (Some of the findings may require customer intervention based on their preferences/needs.)

Backlog item #666 created.

@glennmusa glennmusa self-assigned this Feb 23, 2022
glennmusa
glennmusa suggested changes Feb 23, 2022
View reviewed changes
src/bicep/examples/README.md Outdated Show resolved Hide resolved
src/bicep/examples/zeroTrustWorkbook/README.md Outdated Show resolved Hide resolved
src/bicep/examples/zeroTrustWorkbook/README.md Outdated Show resolved Hide resolved
src/bicep/examples/zeroTrustWorkbook/README.md Outdated Show resolved Hide resolved
src/bicep/examples/zeroTrustWorkbook/README.md Outdated Show resolved Hide resolved
lisamurphy-msft and others added 4 commits February 23, 2022 15:27
@lisamurphy-msft @glennmusa
Update src/bicep/examples/zeroTrustWorkbook/README.md
afbfb49 
Co-authored-by: Glenn Musa <4622125+glennmusa@users.noreply.github.com>
@lisamurphy-msft @glennmusa
Update src/bicep/examples/zeroTrustWorkbook/README.md
5ad859c 
Co-authored-by: Glenn Musa <4622125+glennmusa@users.noreply.github.com>
@lisamurphy-msft @glennmusa
Update src/bicep/examples/zeroTrustWorkbook/README.md
0edeba4 
Looks like with the recent changes to ASC, we now refer to things as Defender

Co-authored-by: Glenn Musa <4622125+glennmusa@users.noreply.github.com>
@lisamurphy-msft @glennmusa
Update src/bicep/examples/README.md
c4fcd89 
Co-authored-by: Glenn Musa <4622125+glennmusa@users.noreply.github.com>
glennmusa
glennmusa previously requested changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@glennmusa glennmusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another small nit

src/bicep/examples/zeroTrustWorkbook/README.md Outdated Show resolved Hide resolved
lisamurphy-msft and others added 12 commits February 25, 2022 09:12
@lisamurphy-msft
Merge branch 'issue-258-temp' of https://github.com/Azure/missionlz i…
591eb25 
…nto issue-258-temp
@lisamurphy-msft
Merge branch 'issue-258-temp' of https://github.com/Azure/missionlz i…
021fad3 
…nto issue-258-temp
@lisamurphy-msft
Merge branch 'issue-258-temp' into main
c064894
@lisamurphy-msft
Merge branch 'main' of https://github.com/Azure/missionlz into main
c5b9935
@lisamurphy-msft
Merge c5b9935 into a0a0cae
bb2eb58
Update Software Bill of Materials (SBOM)
ab34802
@lisamurphy-msft
Merge branch 'main' of https://github.com/Azure/missionlz into main
575cca4
@lisamurphy-msft
Merge 575cca4 into a0a0cae
5e543e9
Update Software Bill of Materials (SBOM)
fdbf98d
@lisamurphy-msft
updates to variables in zerotrustworkbook
950b3c1
@lisamurphy-msft
Merge branch 'issue-258-temp' of https://github.com/Azure/missionlz i…
b986e24 
…nto issue-258-temp
@lisamurphy-msft
Merge b986e24 into a0a0cae
3229aa7
@brooke-hamilton brooke-hamilton enabled auto-merge (squash) February 28, 2022 19:54
@lisamurphy-msft lisamurphy-msft dismissed glennmusa’s stale review February 28, 2022 20:00

Too many changes since this was last requested - can re-visit if additional changes are needed

@brooke-hamilton brooke-hamilton merged commit 3783f5f into main Feb 28, 2022
@brooke-hamilton brooke-hamilton deleted the issue-258-temp branch February 28, 2022 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brooke-hamilton brooke-hamilton brooke-hamilton approved these changes

@glennmusa glennmusa glennmusa left review comments

Assignees

@glennmusa glennmusa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spike: Deploy Zero Trust Workbook to Sentinel
3 participants
@lisamurphy-msft @glennmusa @brooke-hamilton