Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated bundle parameter to include default array #687

Merged
merged 17 commits into from
Mar 4, 2022

Conversation

lisamurphy-msft
Copy link
Contributor

@lisamurphy-msft lisamurphy-msft commented Mar 4, 2022

Description

added in a default empty array value that will not issue a failure if the Microsoft.Security/pricings option is not available in region

Issue reference

The issue this PR will close: #649

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

@lisamurphy-msft lisamurphy-msft requested a review from a team as a code owner March 4, 2022 18:02
@lisamurphy-msft lisamurphy-msft marked this pull request as draft March 4, 2022 18:03
@lisamurphy-msft
Copy link
Contributor Author

Putting this in draft; although it is shown to work in testing there was mention by @brooke-hamilton that we need to include guidance in our documentation for deployment instructions in other clouds to manually enable Pricings for Defender.

@lisamurphy-msft lisamurphy-msft marked this pull request as ready for review March 4, 2022 18:22
@brooke-hamilton brooke-hamilton self-assigned this Mar 4, 2022
Copy link
Contributor

@brooke-hamilton brooke-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. ✨ The empty array looks good. Did you discover that it's not possible to retrieve the list of bundles during the deployment?

I'm running a test deployment but here are my initial comments.

docs/deployment-guide-bicep.md Outdated Show resolved Hide resolved
docs/deployment-guide-bicep.md Outdated Show resolved Hide resolved
src/bicep/modules/defender.bicep Outdated Show resolved Hide resolved
src/bicep/modules/defender.bicep Outdated Show resolved Hide resolved
@lisamurphy-msft lisamurphy-msft dismissed stale reviews from glennmusa and brooke-hamilton March 4, 2022 20:13

e3791a3 addressed requested changes

@brooke-hamilton brooke-hamilton enabled auto-merge (squash) March 4, 2022 20:54
@brooke-hamilton brooke-hamilton merged commit 84d19c7 into main Mar 4, 2022
@brooke-hamilton brooke-hamilton deleted the issue-649-temp branch March 4, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate the Defender pricing bundle array from a resource provider
3 participants