Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breestryker/restructure code #699

Merged
merged 5 commits into from
Apr 4, 2022
Merged

Conversation

Breanna-Stryker
Copy link
Contributor

Description

Rename files and file contents to match new naming schemes. Modify readme's and add brief readmes to the new core and module folders.

Issue reference

The issue this PR will close: #561

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

@Breanna-Stryker Breanna-Stryker requested a review from a team as a code owner March 31, 2022 18:07
@lisamurphy-msft
Copy link
Contributor

lisamurphy-msft commented Apr 4, 2022

Testing to see if this deploys, using these parameters:
$ az deployment sub create --name "testing699" --location eastus --template-file bicep/mlz.bicep --parameters resourcePrefix=test deploySentinel=true deployDefender=true

@lisamurphy-msft
Copy link
Contributor

Deployment completed successfully with all expected resources:
image

Copy link
Contributor

@lisamurphy-msft lisamurphy-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very well done and a significant amount of effort!!!
Testing also shows that the refactoring didn't break any of the deployment logic.
Approving.

@lisamurphy-msft lisamurphy-msft merged commit 8d4ff53 into main Apr 4, 2022
@lisamurphy-msft lisamurphy-msft deleted the breestryker/RestructureCode branch April 4, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the directory structure of the src/bicep folder
2 participants