Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum TLS version enforcement #702

Merged
merged 10 commits into from
Apr 7, 2022
Merged

Conversation

lisamurphy-msft
Copy link
Contributor

@lisamurphy-msft lisamurphy-msft commented Apr 6, 2022

Description

Updated minimum TLS version on storage account assets to 1.2
Also, ensured parity, Terraform had StorageV2, updated the bicep module

Issue reference

The issue this PR will close: #696

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

@lisamurphy-msft lisamurphy-msft requested a review from a team as a code owner April 6, 2022 13:31
Copy link
Contributor

@brooke-hamilton brooke-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ 👍

@brooke-hamilton brooke-hamilton enabled auto-merge (squash) April 7, 2022 15:22
@brooke-hamilton brooke-hamilton merged commit af4f764 into main Apr 7, 2022
@brooke-hamilton brooke-hamilton deleted the issue-697-temp branch April 7, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update storageAccount.bicep to require minimum TLS 1.2
2 participants