Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update defender.bicep with current securitypricing resource types #722

Merged

Conversation

LManning-Dev
Copy link
Contributor

@LManning-Dev LManning-Dev commented Jul 18, 2022

Deploy MLZ with deployDefender=$true

Used Get-AzSecurityPricing to get the latest offerings

Expected behavior
All Defender Resources are set to Standard (Status should be On)

Actual behavior
New Resource Types are missed

Description

Please explain the changes you've made

Issue reference

The issue this PR will close: #720

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

Deploy MLZ with deployDefender=$true

Used Get-AzSecurityPricing to get the latest offerings

Expected behavior
All Defender Resources are set to Standard (Status should be On)

Actual behavior
New Resource Types are missed
@LManning-Dev LManning-Dev requested a review from a team as a code owner July 18, 2022 21:13
@ghost
Copy link

ghost commented Jul 18, 2022

CLA assistant check
All CLA requirements met.

@LManning-Dev
Copy link
Contributor Author

#720

Not sure I had a choice to associate it with the bug.

Thank you

@lisamurphy-msft
Copy link
Contributor

lisamurphy-msft commented Jul 25, 2022

Thank you for updating the pricings data for AzureCloud and AzureUSGovernment environments. The last time it was updated these additional offerings were not available in Microsoft Defender for Cloud. Validated the list is inclusive of the available resource types in the environments provided.

@lisamurphy-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@lisamurphy-msft lisamurphy-msft enabled auto-merge (squash) July 25, 2022 12:59
@lisamurphy-msft
Copy link
Contributor

/azp

@azure-pipelines
Copy link

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@lisamurphy-msft lisamurphy-msft merged commit 0b8718a into Azure:main Jul 25, 2022
@lisamurphy-msft lisamurphy-msft added core New feature or request compliance & security labels Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compliance & security core New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MLZ does not set every Defender Pricing Tier to Standard (possibly out of date) defender.bicep
2 participants