Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tier3 Naming Convention - Add more flexibility and match mlz.bice… #730

Merged

Conversation

LManning-Dev
Copy link
Contributor

@LManning-Dev LManning-Dev commented Jul 20, 2022

…p (core) #729

This Fix fixes the naming convention (Prefix instead of workload) and allows the workload name to be sent as a parameter. Since the workload name could be anything sent by the user, and the storage account name should have additional considerations (like the option to also be a parameter)

Issue reference

The issue this PR will close: #729

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

…p (core) Azure#729

This Fix fixes the naming convention (Prefix instead of workload) and allows the workload name to be sent as a parameter. Since the workload name could be anything sent by the user, and the storage account name should have additional considerations (like the option to also be a parameter)
@LManning-Dev LManning-Dev requested a review from a team as a code owner July 20, 2022 00:58
LManning-Dev and others added 4 commits July 27, 2022 15:20
Adding parameters for workloadName and workloadLogStorageAccountNameParameter to the tier 3 readme
Fixing Lint Error in Tier3 Readme
@lisamurphy-msft lisamurphy-msft enabled auto-merge (squash) September 7, 2022 16:08
@lisamurphy-msft lisamurphy-msft merged commit a5922a9 into Azure:main Sep 7, 2022
@lisamurphy-msft lisamurphy-msft added the core New feature or request label Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tire 3 Naming Convention Does not follow Core mlz.bicep and is not adjustable
2 participants