Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IaaS DNS Forwarders #746

Merged
merged 6 commits into from
Sep 7, 2022
Merged

IaaS DNS Forwarders #746

merged 6 commits into from
Sep 7, 2022

Conversation

FabienGilbert
Copy link
Contributor

Description

Template and Readme to deploy IaaS DNS Forwarders.

Issue reference

The issue this PR will close: #745

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

@FabienGilbert FabienGilbert requested a review from a team as a code owner September 2, 2022 19:47
Copy link
Contributor

@lisamurphy-msft lisamurphy-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for providing an example of how to deploy MLZ with an existing DNS infrastructure!
For customers that use their own DNS, this will help provide a new interoperability!

Two items I would like to see addressed, if possible:

  • remove the zip file in your commit, I don't think this is needed
  • add an entry to the table in the examples README.md to provide an overview of this new example, comment already provided on this.

@lisamurphy-msft
Copy link
Contributor

Thank you for pushing the proposed change!
This looks good and I was able to successfully test this!

@lisamurphy-msft lisamurphy-msft merged commit 0c03c4b into Azure:main Sep 7, 2022
@lisamurphy-msft lisamurphy-msft added the examples Related to content in the `src/bicep/examples` folder label Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Related to content in the `src/bicep/examples` folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DNS resolution flow incomplete
2 participants