Breaking NIST into NISTRev4 and NISTRev5 #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breaking NIST into NISTRev4 and NISTRev5
lisamurphy-msft
suggested changes
Sep 12, 2022
There was a problem hiding this comment.
This is very well done and falls in line with our existing framework.
Thank you for all your hard work on this!
Would you be able to additionally update this README on policies to reflect these proposed changes? https://github.com/Azure/missionlz/blob/main/docs/policies.md
Updating NISTRev4 NISTRev5 comment
…om/LManning-Dev/missionlz into loganmanning/NISTRev4NistRev5_#744
lisamurphy-msft
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking NIST into NISTRev4 and NISTRev5
Description
This change breaks NIST into NISTRev4 and NISTRev5. It defaults to NISTRev4 instead of NIST (and IL5 changes to NISTRev4 instead of NIST) to preserve that functionality
Issue reference
#744 MLZ Should give the option for both NIST Rev4 and Rev5
The issue this PR will close: #744
Checklist
Please make sure you've completed the relevant tasks for this PR out of the following list: