Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IaaS DNS forwarders deployment with default extensions uri + more documentation #753

Merged
merged 2 commits into from
Sep 13, 2022
Merged

Fix IaaS DNS forwarders deployment with default extensions uri + more documentation #753

merged 2 commits into from
Sep 13, 2022

Conversation

FabienGilbert
Copy link
Contributor

Description

Fixed deployment with extensionsFilesContainerUri defaulting to public Repo and added more documentation

Issue reference

The issue this PR will close: #752

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

@FabienGilbert FabienGilbert requested a review from a team as a code owner September 13, 2022 14:57
@lisamurphy-msft lisamurphy-msft merged commit 54188f8 into Azure:main Sep 13, 2022
@lisamurphy-msft lisamurphy-msft added the examples Related to content in the `src/bicep/examples` folder label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lisamurphy-msft lisamurphy-msft lisamurphy-msft approved these changes

Assignees
No one assigned
Labels
examples Related to content in the `src/bicep/examples` folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IaaS DNS Forwarders don't deploy with extensions in default repo
2 participants
@FabienGilbert @lisamurphy-msft