Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Bicep deploy-time warnings #754

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

BrandonSharp
Copy link
Contributor

@BrandonSharp BrandonSharp commented Sep 14, 2022

Description

Syntax changes to address deploy-time warnings.

use-resource-id-functions - fixed by referencing the built-in policy defs using tenantResourceId() as described here: https://docs.microsoft.com/en-us/azure/azure-resource-manager/bicep/bicep-functions-resource#tenantresourceid

prefer-unquoted-property-names - removed single quotes from keys in the defaultTags variable in mlz.bicep

no-unused-existing-resources - fixed by removing unused securityContacts resource from log-analytics-diagnostic-logging.bicep

use-stable-resource-identifiers - This warning was fixed as a result of prior work done in PR #748

Remaining changes are VSCode formatting artifacts, which I can revert if necessary/desired.

Issue reference

The issue this PR will close: #743

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

@BrandonSharp BrandonSharp requested a review from a team as a code owner September 14, 2022 23:03
@lisamurphy-msft lisamurphy-msft enabled auto-merge (squash) September 15, 2022 19:19
@lisamurphy-msft lisamurphy-msft merged commit 320881f into Azure:main Sep 15, 2022
@lisamurphy-msft lisamurphy-msft added the core New feature or request label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Warning Messages in MLZ.
2 participants