Implement Sub ID array for Role assignment #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added code to create sub id array
glennmusa
reviewed
Mar 12, 2021
glennmusa
reviewed
Mar 12, 2021
glennmusa
reviewed
Mar 12, 2021
There was a problem hiding this comment.
Everything seems to work. I added some feedback for your consideration and think we can suppress the WARNING when creating the service principal.
Dunno if there are conflicts, but be sure to take care when merging your other open PR that is approved and not yet merged.
glennmusa
approved these changes
Mar 16, 2021
Breanna-Stryker
added a commit
that referenced
this pull request
Mar 19, 2021
* add the shellcheck extension to the devcontainer (#70) Co-authored-by: Glenn Musa <glennmusa@users.noreply.github.com> * Enable Azure Security Center in MLZ subscriptions (#55) * Updated documentation in script * - Added execution flag to shell scripts - Added configure_asc.sh script - Added code to create subs array to mlz_tf_setup.sh - Added code to call configure_asc.sh from mlz_tf_setup.sh * - Added executable flag to unzipprovider.sh script * - Added executable flag to check scripts * - Updated loop code for workspace setting * - Created folder for ASC scripts - Copied generate_names.sh script into ASC folder * - Removed ASC calling code from setup script - Updated naming in asc script - Added ASC naming to generate script * - Moved LAWS name generation into generate names - Moved generate names call into loop - Updated wait loop to use variables * - Removed message for elapsed time - Added quotes consistently for echo's * - Updated Copyright statement - Added set -e - Modified variables to use env & location from vars file * - Corrected counter logic - Corrected description in names script * output number of attempts remaining * add a comment that this may fail * - Removed creater comment * unusually typo Co-authored-by: Glenn Musa <glennmusa@users.noreply.github.com> * Add persona and business justification to the Issue template (#73) * issue template update * Implement error handling into shell scripts (#72) * - Added error handling to configure_asc script - Suppressed "create" output in configure_asc script * - Added error handling to config_create script - Remove commented lines from configure_asc script * - Added error handling to config_validate script * - Added error handling to get_sp_identity script - Corrected SP lookup * - Added error handling to mlz_config_create script * - Updated echo lines * Implement Sub ID array for Role assignment (#76) * - Updated bullet numbering in README - Added code to create sub id array * - Reverted numbering changes made to README.md * - Added description of sed command * - Added parameter to suppress WARNING on sp create * Remove providers (#84) * use azurerm 2.50 in src/core * removing provider files * updates to readme and scripts for local providers * set tf provider folder Co-authored-by: Glenn Musa <glennmusa@users.noreply.github.com> * unique diagnostic settings names (#82) Co-authored-by: Glenn Musa <glennmusa@users.noreply.github.com> * move scripts to src/scripts (#87) * add a workflow for apply and destroy terraform (#83) * add retries for apply and destroy * update readmes Co-authored-by: Glenn Musa <4622125+glennmusa@users.noreply.github.com> Co-authored-by: Glenn Musa <glennmusa@users.noreply.github.com> Co-authored-by: Byron Boudreaux <16844071+Phydeauxman@users.noreply.github.com> Co-authored-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com> Co-authored-by: Breanna-Stryker <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue reference
The issue this PR will close: #75
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
shellcheck.vscode/extensions.json.)