Added zero trust configs for storage & virtual machines #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jan 22, 2024
mikedzikowski
approved these changes
Jan 22, 2024
This was
linked to
issues
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes add zero trust configurations to the storage accounts and virtual machines. For the storage accounts, public access is disabled and relies on private endpoints for connectivity. Also, the storage account configuration has been optimized for security. Lastly, the encryption has been updated to use a customer managed key with auto rotation policy. For the virtual machines, customer managed keys have been added to the disks along with trusted launch and encryption at host. The hybrid use benefit has been exposed so customers may take advantage of that capability to reduce cost. MLZ had to be changed significantly to modify the deployment order. The enhancements included in this PR will allow for idempotent deployments now. Other smaller changes were around naming. The location abbreviation has been added. Resource names are consistently named throughout.
Issue reference
The issues this PR will close:
Please make sure you've completed the relevant tasks for this PR out of the following list: