Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to allow optional identity resources #838

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Updates to allow optional identity resources #838

merged 1 commit into from
Feb 2, 2024

Conversation

jamasten
Copy link
Contributor

@jamasten jamasten commented Feb 2, 2024

PR resolves the linked feature request. The code included some other enhancements:

  • Virtual Network Links for the Private DNS Zones are now added to the identity VNET when those resources are deployed. If the identity resources are not deployed, links are only created on the hub VNET. In both scenarios, the hub VNET is linked so the MLZ resources continue to work until the DC or Entra Domain Services is established.
  • Refactored the "private-dns.bicep" file to remove repetitive code

@jamasten jamasten requested a review from a team as a code owner February 2, 2024 06:14
@jamasten jamasten linked an issue Feb 2, 2024 that may be closed by this pull request
make identity deployment optional for cloud native customer #807
Closed
@mikedzikowski mikedzikowski enabled auto-merge (squash) February 2, 2024 16:10
mikedzikowski
mikedzikowski approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@mikedzikowski mikedzikowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing!

@mikedzikowski mikedzikowski merged commit a143c5c into main Feb 2, 2024
1 of 3 checks passed
@mikedzikowski mikedzikowski deleted the 807-make-identity-deployment-optional-for-cloud-native-customer branch February 2, 2024 16:35
@jamasten jamasten linked an issue Feb 13, 2024 that may be closed by this pull request
MLZ: Add Virtual Network Links to the Identity VNET #799
Closed
@jamasten jamasten self-assigned this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikedzikowski mikedzikowski mikedzikowski approved these changes

Assignees

@jamasten jamasten

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jamasten @mikedzikowski