Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added network watcher to unique spokes #902

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Added network watcher to unique spokes #902

merged 2 commits into from
Feb 19, 2024

Conversation

jamasten
Copy link
Contributor

This change also ensures activity log diagnostic settings are not duplicated on subscriptions.

@jamasten jamasten requested a review from a team as a code owner February 17, 2024 04:22
@jamasten jamasten linked an issue Feb 17, 2024 that may be closed by this pull request
MLZ: Ensure network watcher is created for each tier #893
Closed
@jamasten jamasten enabled auto-merge (squash) February 17, 2024 04:24
@jamasten
Copy link
Contributor Author

@mikedzikowski for your awareness, this change was tested in 3 scenarios:

  • one sub; outcome: deployed to hub
  • two subs; outcome: deployed to hub and shared services; ops and identity shared subs with the other two so no network watchers
  • four subs; outcome: deployed to each sub

@jamasten jamasten merged commit 5dcb1ca into main Feb 19, 2024
1 check passed
@jamasten jamasten deleted the 893-network-watcher-for-each-tier branch February 19, 2024 22:54
@jamasten jamasten self-assigned this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikedzikowski mikedzikowski mikedzikowski approved these changes

Assignees

@jamasten jamasten

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MLZ: Ensure network watcher is created for each tier
2 participants
@jamasten @mikedzikowski