Ezdeploy #99
Merged
Ezdeploy #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bring Main Branch to Working Branch
* add the shellcheck extension to the devcontainer (#70) Co-authored-by: Glenn Musa <glennmusa@users.noreply.github.com> * Enable Azure Security Center in MLZ subscriptions (#55) * Updated documentation in script * - Added execution flag to shell scripts - Added configure_asc.sh script - Added code to create subs array to mlz_tf_setup.sh - Added code to call configure_asc.sh from mlz_tf_setup.sh * - Added executable flag to unzipprovider.sh script * - Added executable flag to check scripts * - Updated loop code for workspace setting * - Created folder for ASC scripts - Copied generate_names.sh script into ASC folder * - Removed ASC calling code from setup script - Updated naming in asc script - Added ASC naming to generate script * - Moved LAWS name generation into generate names - Moved generate names call into loop - Updated wait loop to use variables * - Removed message for elapsed time - Added quotes consistently for echo's * - Updated Copyright statement - Added set -e - Modified variables to use env & location from vars file * - Corrected counter logic - Corrected description in names script * output number of attempts remaining * add a comment that this may fail * - Removed creater comment * unusually typo Co-authored-by: Glenn Musa <glennmusa@users.noreply.github.com> Co-authored-by: Glenn Musa <4622125+glennmusa@users.noreply.github.com> Co-authored-by: Glenn Musa <glennmusa@users.noreply.github.com> Co-authored-by: Byron Boudreaux <16844071+Phydeauxman@users.noreply.github.com>
… info from script.
glennmusa
reviewed
Mar 23, 2021
glennmusa
reviewed
Mar 23, 2021
glennmusa
reviewed
Mar 23, 2021
Comment on lines
+6
to
+9
| # shellcheck disable=SC1090,SC1091 | ||
| # SC1090: Can't follow non-constant source. Use a directive to specify location. | ||
| # SC1091: Not following. Shellcheck can't follow non-constant source. | ||
| # SC2154: "var is referenced but not assigned". These values come from an external file. |
There was a problem hiding this comment.
getting lots of shellcheck warnings because SC2154 isn't disabled on L6, unfamiliar here so I don't want to make an update and miss something that is a true positive
brooke-hamilton
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull wraps up the first iteration of ezdeploy. Testing is pending, as of 3/21 there appears to be an issue with the azure CLI, will retry 3/22. Pre-deployment packaging for AGC isn't fully completed, pending remote deployment tests.
Issue reference
The issue this PR will close: #30, #31, #32, #33, #20, #69, #40
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
shellcheck.vscode/extensions.json.)