Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: TCGC would return customized error model by default #1587

Open
4 tasks done
MaryGao opened this issue Sep 20, 2024 · 0 comments
Open
4 tasks done

[Bug]: TCGC would return customized error model by default #1587

MaryGao opened this issue Sep 20, 2024 · 0 comments
Labels
bug Something isn't working lib:tcgc Issues for @azure-tools/typespec-client-generator-core library

Comments

@MaryGao
Copy link
Contributor

MaryGao commented Sep 20, 2024

Describe the bug

See playground we have customized error model defined ResponseError.

import "@typespec/rest";

@error
model ResponseError {
  code: int32;
  meesage: string;
}

op test(): void | ResponseError;

Currently it is always returning this error model in TCGC during getAllModels but please note if this error model is defined in azure core, by default we will not return that model. I think it's better to have an option to opt in if we need this model and by default not returning this like azure error model.
image

Reproduction

NA

Checklist

  • Follow our Code of Conduct
  • Check that this issue is about the Azure libraries for typespec. For bug in the typespec language or core libraries file it in the TypeSpec repo
  • Check that there isn't already an issue that request the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.
@MaryGao MaryGao added the bug Something isn't working label Sep 20, 2024
@tadelesh tadelesh added lib:tcgc Issues for @azure-tools/typespec-client-generator-core library and removed needs-area labels Sep 20, 2024
@Azure Azure deleted a comment Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lib:tcgc Issues for @azure-tools/typespec-client-generator-core library
Projects
None yet
Development

No branches or pull requests

2 participants