Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade compiler to v0.60.x and tcgc in Sep. #2819

Merged
merged 9 commits into from
Sep 20, 2024
Merged

Upgrade compiler to v0.60.x and tcgc in Sep. #2819

merged 9 commits into from
Sep 20, 2024

Conversation

v-jiaodi
Copy link
Member

@v-jiaodi v-jiaodi commented Sep 11, 2024 •
edited
Loading

Upgrade compiler version to v0.60.0
Upgrade tcgc version to v0.46.1

Error log:

Invoking: tsc -p .
src/modular/buildCodeModel.ts(1385,34): error TS2339: Property 'values' does not exist on type 'SdkUnionType<SdkType>'.
src/modular/buildCodeModel.ts(1385,46): error TS7006: Parameter 'x' implicitly has an 'any' type.
src/modular/buildCodeModel.ts(1412,31): error TS7006: Parameter 'x' implicitly has an 'any' type.
src/modular/emitSamples.ts(11,3): error TS2724: '"@azure-tools/typespec-client-generator-core"' has no exported member named 'SdkHttpParameterExample'. Did you mean 'SdkHttpParameterExampleValue'?
src/modular/emitSamples.ts(15,3): error TS2305: Module '"@azure-tools/typespec-client-generator-core"' has no exported member 'SdkTypeExample'.
src/modular/emitSamples.ts(448,42): error TS7006: Parameter 'element' implicitly has an 'any' type.
src/utils/credentialUtils.ts(76,47): error TS2339: Property 'values' does not exist on type 'SdkUnionType<SdkCredentialType>'.

@v-jiaodi v-jiaodi changed the title Upgrade compiler and tcgc in Sep Upgrade compiler and tcgc in Sep. Sep 11, 2024
@MaryGao MaryGao marked this pull request as ready for review September 12, 2024 02:04
@MaryGao MaryGao changed the title Upgrade compiler and tcgc in Sep. Upgrade compiler to v0.60.x and tcgc in Sep. Sep 12, 2024
@MaryGao
Copy link
Contributor

MaryGao commented Sep 12, 2024

Hold on until the issue is fixed: Azure/typespec-azure#1532.

@MaryGao MaryGao added the HoldOn label Sep 12, 2024
@MaryGao MaryGao changed the title Upgrade compiler to v0.60.x and tcgc in Sep. [holdon]Upgrade compiler to v0.60.x and tcgc in Sep. Sep 12, 2024
@MaryGao MaryGao self-requested a review September 19, 2024 08:02
@MaryGao MaryGao changed the title [holdon]Upgrade compiler to v0.60.x and tcgc in Sep. Upgrade compiler to v0.60.x and tcgc in Sep. Sep 20, 2024
@MaryGao MaryGao removed the HoldOn label Sep 20, 2024
MaryGao
MaryGao reviewed Sep 20, 2024
View reviewed changes
packages/typespec-test/test/anomalyDetector/generated/typespec-ts/src/models/models.ts
@@ -687,3 +687,11 @@ export interface UnivariateUnivariateChangePointDetectionResult {

/** Type of Versions */
export type Versions = "v1.1";

/** Error response */
export interface MultivariateResponseError {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this model is generated?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue tracked here: Azure/typespec-azure#1587

@MaryGao MaryGao merged commit cd429be into Azure:main Sep 20, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaryGao MaryGao MaryGao approved these changes

@sarangan12 sarangan12 Awaiting requested review from sarangan12 sarangan12 is a code owner

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

@qiaozha qiaozha Awaiting requested review from qiaozha qiaozha is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v-jiaodi @MaryGao