Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][TCGC] the bumped parameter in method.operation should not onClient=false #1532

Closed
chunyu3 opened this issue Sep 12, 2024 · 0 comments
Closed
Labels
lib:tcgc Issues for @azure-tools/typespec-client-generator-core library

Comments

@chunyu3
Copy link
Member

chunyu3 commented Sep 12, 2024

When use @clientInitialization to bump a operation parameter to client level. The onClient=false of the parameter in operation.

model clientInitModel
{
    p1: string;
}

@route("/bump")
@clientInitialization(clientInitModel)
interface bumpParameter {
    @route("/op1")
    @doc("bump parameter")
    @post
    @convenientAPI(true)
    op op1(@path p1: string, @query q1: string): void;

    @route("/op2")
    @doc("bump parameter")
    @post
    @convenientAPI(true)
    op op2(@path p1: string): void;
}

expected:
onClient = true

actual:
onClient = false
image

@chunyu3 chunyu3 added lib:tcgc Issues for @azure-tools/typespec-client-generator-core library and removed needs-area labels Sep 12, 2024
tadelesh pushed a commit that referenced this issue Sep 18, 2024
…ientInitialization (#1554)

fixes #1532

---------

Co-authored-by: iscai-msft <isabellavcai@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib:tcgc Issues for @azure-tools/typespec-client-generator-core library
Projects
None yet
Development

No branches or pull requests

2 participants