Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TCGC] Fix client initialization for subscriptionId #1476

Merged
merged 10 commits into from
Sep 5, 2024
Merged

[TCGC] Fix client initialization for subscriptionId #1476

merged 10 commits into from
Sep 5, 2024

Conversation

msyyc
Copy link
Member

@msyyc msyyc commented Sep 4, 2024 •
edited
Loading

  • Before fix:
    image
  • After fix:
    image

@microsoft-github-policy-service microsoft-github-policy-service bot added the lib:tcgc Issues for @azure-tools/typespec-client-generator-core library label Sep 4, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Sep 4, 2024 •
edited
Loading

All changed packages have been documented.

  • ✅ @azure-tools/typespec-client-generator-core
Show changes

@azure-tools/typespec-client-generator-core - fix ✏️

Fix to add client signature subscriptionId for ARM SDK

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

@msyyc msyyc marked this pull request as ready for review September 5, 2024 05:36
@iscai-msft
Copy link
Contributor

thanks @msyyc!

@iscai-msft iscai-msft added this pull request to the merge queue Sep 5, 2024
Merged via the queue into main with commit 607bd26 Sep 5, 2024
22 checks passed
@iscai-msft iscai-msft deleted the fix-tcgc-client-init branch September 5, 2024 15:37
markcowl pushed a commit to markcowl/typespec-azure that referenced this pull request Sep 7, 2024
@msyyc @markcowl
[TCGC] Fix client initialization for subscriptionId (Azure#1476)
e197716 
- Before fix:

![image](https://github.com/user-attachments/assets/0e825a28-c8fd-4683-a3a7-a7d5e038ab17)
- After fix:

![image](https://github.com/user-attachments/assets/501821ea-b31a-4b95-ad33-bd3f437e933f)

---------

Co-authored-by: iscai-msft <isabellavcai@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadelesh tadelesh tadelesh approved these changes

@iscai-msft iscai-msft iscai-msft approved these changes

@weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft approved these changes

@lmazuel lmazuel Awaiting requested review from lmazuel lmazuel is a code owner

@m-nash m-nash Awaiting requested review from m-nash m-nash is a code owner

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

@timotheeguerin timotheeguerin Awaiting requested review from timotheeguerin timotheeguerin is a code owner

@haolingdong-msft haolingdong-msft Awaiting requested review from haolingdong-msft

Assignees
No one assigned
Labels
lib:tcgc Issues for @azure-tools/typespec-client-generator-core library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@msyyc @azure-sdk @iscai-msft @tadelesh @weidongxu-microsoft @haolingdong-msft