revert to previous behavior where Uri.IsAbsolute only checked when no…

…t null.

Updated runTests.ps1 to be the same as build.ps1
Updated strongNameBypass to include Tests (WsFederation, Saml, OIDC, CrossVersionTokenValidation)

runTests.ps1

@@ -52,8 +52,8 @@ foreach ($testProject in $testProjects)
         Write-Host ">>> Set-Location $root\test\$name"
         pushd
         Set-Location $root\test\$name
-        Write-Host ">>> Start-Process -wait -passthru -NoNewWindow $dotnetexe 'test $name.csproj'--no-build --no-restore -nodereuse:false -v d -c $buildType"
-        $p = Start-Process -wait -passthru -NoNewWindow $dotnetexe "test $name.csproj --no-build --no-restore -nodereuse:false -v d -c $buildType"
+        Write-Host ">>> Start-Process -Wait -PassThru -NoNewWindow $dotnetexe 'test $name.csproj' --filter category!=nonwindowstests --no-build --no-restore -nodereuse:false -v n -c $buildType"
+        $p = Start-Process -Wait -PassThru -NoNewWindow $dotnetexe "test $name.csproj --filter category!=nonwindowstests --no-build --no-restore -nodereuse:false -v n -c $buildType"
 
         if($p.ExitCode -ne 0)
         {

runtests.cmd

@@ -0,0 +1,2 @@
+@ECHO OFF
+PowerShell -NoProfile -NoLogo -ExecutionPolicy unrestricted -Command "[System.Threading.Thread]::CurrentThread.CurrentCulture = ''; [System.Threading.Thread]::CurrentThread.CurrentUICulture = '';& '%~dp0runtests.ps1' %*; exit $LASTEXITCODE"

src/Microsoft.IdentityModel.Tokens.Saml/Saml2/Saml2AuthenticationContext.cs

@@ -119,10 +119,7 @@ public Uri DeclarationReference
             get { return _declarationReference; }
             set
             {
-                if (value == null)
-                    throw LogArgumentNullException(nameof(value));
-
-                if (!value.IsAbsoluteUri)
+                if (value != null && !value.IsAbsoluteUri)
                     throw LogExceptionMessage(new ArgumentException(FormatInvariant(LogMessages.IDX13300, nameof(DeclarationReference), value)));
 
                 _declarationReference = value;

test/Microsoft.IdentityModel.Tokens.Saml.Tests/Saml2AuthenticationContextTests.cs

@@ -61,8 +61,7 @@ public void Saml2AuthenticationContext_CtorNullClassAndDeclaration_ArgumentNullE
         [Fact]
         public void Saml2AuthenticationContext_CtorNullDeclaration_ArgumentNullException()
         {
-            var classRef = new Uri("http://resource", UriKind.Absolute);
-            Assert.Throws<ArgumentNullException>(() => new Saml2AuthenticationContext(classRef, null));
+            new Saml2AuthenticationContext(new Uri("http://resource", UriKind.Absolute), null);
         }
 
         [Fact]
@@ -117,10 +116,12 @@ public void Saml2AuthenticationContext_AbsoluteDeclarationReference_NoException(
         }
 
         [Fact]
-        public void Saml2AuthenticationContext_NullDeclarationReference_ArgumentNullException()
+        public void Saml2AuthenticationContext_NullDeclarationReference()
         {
-            var authContext = new Saml2AuthenticationContext();
-            Assert.Throws<ArgumentNullException>(() => authContext.DeclarationReference = null);
+            new Saml2AuthenticationContext
+            {
+                DeclarationReference = null
+            };
         }
     }
 }