skip purchase phone number sample in smoke testing (Azure#13198)

AzureSDKAutomation · Jan 13, 2021 · 90d62de · 90d62de
1 parent dd6ac8c
commit 90d62de
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 8 deletions.
diff --git a/sdk/communication/communication-administration/package.json b/sdk/communication/communication-administration/package.json
@@ -126,5 +126,10 @@
     "sinon": "^9.0.2",
     "typescript": "4.1.2",
     "typedoc": "0.15.0"
+  },
+  "//smokeTestConfiguration": {
+    "skip": [
+      "purchasePhoneNumber.js"
+    ]
   }
 }
diff --git a/sdk/communication/communication-administration/samples/javascript/purchasePhoneNumber.js b/sdk/communication/communication-administration/samples/javascript/purchasePhoneNumber.js
@@ -40,10 +40,10 @@ async function main() {
   // poll until phone number reservation is made
   const reservation = await reservationPoller.pollUntilDone();
 
-  console.log("Phone number reserved for purchase.");
-  console.log(`Reservation: ${JSON.stringify(reservation)}`);
-
   if (reservation.reservationId && reservation.phoneNumbers && reservation.phoneNumbers.length) {
+    console.log("Phone number reserved for purchase.");
+    console.log(`Reservation: ${JSON.stringify(reservation)}`);
+
     const phoneNumber = reservation.phoneNumbers[0];
 
     // create purchase poller
@@ -58,7 +58,7 @@ async function main() {
 
     console.log(`Phone number, ${phoneNumber}, purchased successfully.`);
   } else {
-    throw new Error("No phone numbers found.");
+    console.log("No phone number found matching request.");
   }
 }
 

diff --git a/sdk/communication/communication-administration/samples/typescript/src/purchasePhoneNumber.ts b/sdk/communication/communication-administration/samples/typescript/src/purchasePhoneNumber.ts
@@ -44,10 +44,10 @@ export const main = async () => {
   // poll until phone number reservation is made
   const reservation = await reservationPoller.pollUntilDone();
 
-  console.log("Phone number reserved for purchase.");
-  console.log(`Reservation: ${JSON.stringify(reservation)}`);
-
   if (reservation.reservationId && reservation.phoneNumbers && reservation.phoneNumbers.length) {
+    console.log("Phone number reserved for purchase.");
+    console.log(`Reservation: ${JSON.stringify(reservation)}`);
+
     const phoneNumber = reservation.phoneNumbers[0];
 
     // create purchase poller
@@ -62,7 +62,7 @@ export const main = async () => {
 
     console.log(`Phone number, ${phoneNumber}, purchased successfully.`);
   } else {
-    throw new Error("No phone numbers found.");
+    console.log("No phone number found matching request.");
   }
 };