Skip to content

Commit

Permalink
[app-configuration] Fix selecting ConfigurationSetting fields when th…
Browse files Browse the repository at this point in the history
…ey contain an underscore (Azure#13258)

Fixing problem where some fields could not be properly `select`'d for ConfigurationSettings because they had an underscore.

This revealed some other underlying issues (like inconsistency in how the `select` field was populated in GetConfigurationSetting vs the List*Setting operations). Tests have been added, code refactored and hopefully things look better after this.

Fixes Azure#13126
  • Loading branch information
richardpark-msft committed Jan 20, 2021
1 parent bf98692 commit b5092d1
Show file tree
Hide file tree
Showing 16 changed files with 6,684 additions and 16,896 deletions.
3 changes: 3 additions & 0 deletions sdk/appconfiguration/app-configuration/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## 1.1.1 (Unreleased)

- Fix issues with `select`ing fields to be returned from `listConfigurationSettings`, `listConfigurationRevisions`
and `getConfigurationSetting` where `last_modified` and `content_type` could not properly be passed in.
[PR #13258](https://github.com/Azure/azure-sdk-for-js/pull/13258)

## 1.1.0 (2020-07-07)

Expand Down
4 changes: 2 additions & 2 deletions sdk/appconfiguration/app-configuration/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,9 @@
"integration-test:node": "npm run build:test:node && nyc mocha -r esm --require source-map-support/register --reporter ../../../common/tools/mocha-multi-reporter.js --timeout 180000 --full-trace dist-esm/test/*.spec.js dist-esm/test/**/*.spec.js",
"test:browser": "npm run clean && npm run build:test:browser && npm run unit-test:browser",
"test:node": "npm run clean && npm run build:test:node && npm run unit-test:node",
"test": "npm run clean && npm run build:test && npm run unit-test",
"test": "npm run test:node && npm run test:browser",
"unit-test:browser": "",
"unit-test:node": "mocha --require source-map-support/register --reporter ../../../common/tools/mocha-multi-reporter.js --timeout 180000 --full-trace test-dist/index.node.js",
"unit-test:node": "npm run build:test:node && mocha --require source-map-support/register --reporter ../../../common/tools/mocha-multi-reporter.js --timeout 180000 --full-trace test-dist/index.node.js",
"unit-test": "npm run unit-test:node && npm run unit-test:browser",
"docs": "typedoc --excludePrivate --excludeNotExported --excludeExternals --stripInternal --mode file --out ./dist/docs ./src"
},
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit b5092d1

Please sign in to comment.